Fixed cancel_quit on windows not doing anything #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually I find a questionable thing inside my implementation: should the What do you think? |
|
@not-fl3 Any status update on this? |
|
Ohhh, missed it. I do not have a windows machine to properly test it, tho it looks like it works fine with wine? Anyway, lets merge it, will see if there going to be any bug reports! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At current implementation
cancel_quitwas completely ignored on Windows - the event that could result in preventing quitting the app, was checked after already sendingPostQuitMessage(0).The PR was reasonably tested on Windows in few different configurations. Namely, the
cancel_quitmay acquirenative_display, so the variable was drop just before entering an event, and restored after. This prevents deadlock in this event.For easier following the flow, canceling inside
quit_requested_event()is actually settingd.quit_requestedtofalseat line 295